Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Teambase name updates #477

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Teambase name updates #477

merged 1 commit into from
Jun 25, 2020

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Jun 24, 2020

Allow a custom name to be used for the teambase, and handle different capitalization for teambase config.

Address issue #436

Signed-off-by: Nate Koenig nate@openrobotics.org

Allow a custom name to be used for the teambase, and handle different…
bda75a4 
… capitalization for teambase config

Signed-off-by: Nate Koenig <nate@openrobotics.org>
iche033
iche033 reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good to me.

TEAMBASE is still hardcoded in virtual_stix.ign - should we update that too? We're not really using that launch file for the circuits.

@nkoenig
Copy link
Contributor Author

nkoenig commented Jun 24, 2020

Changes looks good to me.

TEAMBASE is still hardcoded in virtual_stix.ign - should we update that too? We're not really using that launch file for the circuits.

Yeah, I left virtual_stix out because it has other problems that need to be addressed.

@nkoenig nkoenig merged commit 9630c74 into cave_feature_release3 Jun 25, 2020
@nkoenig nkoenig deleted the teambase_name_update branch December 10, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iche033 iche033 iche033 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkoenig @iche033