Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Go OS detector #204

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Use Go OS detector #204

merged 1 commit into from
Nov 11, 2022

Conversation

ambroise-arm
Copy link
Contributor

Based on distro-detect.

Directly compile a static binary without using staticx. Which gives flexibility on the runtime architecture.

Fix #177

@ambroise-arm ambroise-arm requested a review from tfoote as a code owner October 25, 2022 08:02
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, that was way simpler than I had thought. It looks good but I want to do a few more tests before I approve it.

Is there documentation of what distros this covers?

src/rocker/os_detector.py Show resolved Hide resolved
Based on the distro-detect project.

Directly compile a static binary without using staticx. Which gives
flexibility on the runtime architecture.

Issue-Id: SCM-5067
Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Change-Id: I271e90e8e62f2065d0b827823ae5b3d162ad5e14
@ambroise-arm
Copy link
Contributor Author

Is there documentation of what distros this covers?

I didn't see that documented, but https://github.com/dekobon/distro-detect/blob/5f5b9c724b9d9a117732d2a4292e6288905734e1/linux/distro.go#L225 lists the distributions that can be detected.

Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I've manually tested with arm64 and armhf images on my desktop.

@tfoote tfoote merged commit 721d1e3 into osrf:main Nov 11, 2022
ambroise-arm added a commit to ambroise-arm/autoware-documentation that referenced this pull request Dec 6, 2023
The troubleshooting section referred to a bug that has been fixed with
osrf/rocker#204, which is applied to rocker
version 0.2.11 and above.

Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
ambroise-arm added a commit to ambroise-arm/autoware-documentation that referenced this pull request Feb 23, 2024
The troubleshooting section referred to a bug that has been fixed with
osrf/rocker#204, which is applied to rocker
version 0.2.11 and above.

Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OS detection failing on Jetson Xavier
2 participants