-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Go OS detector #204
Use Go OS detector #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, that was way simpler than I had thought. It looks good but I want to do a few more tests before I approve it.
Is there documentation of what distros this covers?
Based on the distro-detect project. Directly compile a static binary without using staticx. Which gives flexibility on the runtime architecture. Issue-Id: SCM-5067 Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com> Change-Id: I271e90e8e62f2065d0b827823ae5b3d162ad5e14
3345d43
to
e9f3389
Compare
I didn't see that documented, but https://github.com/dekobon/distro-detect/blob/5f5b9c724b9d9a117732d2a4292e6288905734e1/linux/distro.go#L225 lists the distributions that can be detected. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks I've manually tested with arm64 and armhf images on my desktop.
The troubleshooting section referred to a bug that has been fixed with osrf/rocker#204, which is applied to rocker version 0.2.11 and above. Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
The troubleshooting section referred to a bug that has been fixed with osrf/rocker#204, which is applied to rocker version 0.2.11 and above. Signed-off-by: Ambroise Vincent <ambroise.vincent@arm.com>
Based on distro-detect.
Directly compile a static binary without using staticx. Which gives flexibility on the runtime architecture.
Fix #177