-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Humble + Garden #83
Conversation
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina I missed this PR while getting a version to build for macOS and duplicated the bulk of the work in #89 🙄. I've closed that PR and extracted the main differences (which mostly have to do with dependencies on ros_gz_bridge and ros_gz_sim) into this commit srmainwaring@8c886be which was obtained after merging a fork of Happy to help with testing for macOS if you need it. |
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
- Update library and namespaces for ign -> gz migration. - Use `python -m em` rather than `empy` for macOS support. - Update dependencies to ros_gz_bridge and ros_gz_sim Signed-off-by: Rhys Mainwaring <rhys.mainwaring@me.com>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Updated with your commit @srmainwaring, made some small changes to fix the errors I was getting. This should be now ready, will iterate as required after Gazebo Garden release. |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@andermi I'm down to one test that times out. The
|
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
The only test failures here appear to be timeouts now @andermi |
I'll try the |
@mjcarroll this is looking good on macOS as well. There is one catch which is that the header for As a workaround I've created a ros2 / ament build of https://github.com/dstahlke/gnuplot-iostream on this branch I may have missed a ros2 package for gnuplot-iostream elsewhere, but if it's not available is there any interest in upstreaming one? |
To be followed up on another PR |
WIP