-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding viscous drag via hydrodynamics plugin #32
Conversation
Signed-off-by: quarkytale <dharini@openrobotics.org>
Signed-off-by: quarkytale <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Test in conjunction with garden's added mass. Zero out the added mass terms in the hydrodynamics plugin but keep the viscous drag coefficients. Does this yield something sane/stable? @andermi to give @quarkytale nominal drag values. |
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@hamilton8415 @andermi @mjcarroll Picking this up again. I added two buoys in a test world
To try this, run two_buoys.mp4 |
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
@andermi @hamilton8415 I'm not sure why but this is not being stable independently. Putting a pin on the sign, I can only run the sim with added mass #115 in or if I reduce the damping values from the range of 1000s to 100s. To run the world, |
cc24457
to
d1da74a
Compare
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Comments on line 485 and 498 in model.sdf.em should refer to "Pitch" instead of "Roll"... |
Nice to see these tests passing on CI, although I can't get the to pass locally (I never can...). In any event, I am going to do a final review of the drag values this morning with Rob McEwen so hopefully we can merge this today if the tests really are passing. |
Signed-off-by: Dharini Dutia <dharini@openrobotics.org>
Updated with the new drag values. Tests are passing for me locally too. Are we defaulting the heave cone to be doors closed? Also, need advice on whether to keep the test world for testing values in future? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked the sdf values and they match the documentation. I also built and ran this and the buoy behaved as one would expect. I am not able to get the tests to pass locally, although I see they are fine on the CI. This seems to be a problem for me locally recently, if they pass for you locally as well as on CI, merge away.
@quarkytale @hamilton8415 is there anything left to do here or can I merge this so I can merge batch running? |
I say merge and move on. We will come back after the waves are merged as we've discussed. |
Adding Gazebo's Hydrodynamics plugin on the heave cone.
Try the test world
ign gazebo src/buoy_sim/buoy_gazebo/worlds/test_heave_cone_model.sdf -v
to play with different values of plugin parameters.Parameters
Given: Added mass in z-direction, surface area and drag coefficient.
The quadratic damping, Zww (kg/m) = 0.5 * rho * C_d * A
where rho is density of water (kg/m^3), C_d is the drag coefficient, and A is the surface are of the cone (m^2)
A simple approach to test, used the average drag coefficient up/down to calculate Zww.
Zww(open) = 2700.10625 kg/m, Zww(close) = 3782.25 kg/m
Updated the plugin parameters and with the given properties.
Issues
With the current upstream plugin, we can't change the parameters dynamically for heave cone's open/close as well as up/down motion.
Discussion