update tutorials

[andermi]

update tutorials for new pack rate service and use non-blocking for python

[github-actions]

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-06-06 19:25 UTC

[quarkytale]

Changes look good to me, but the preview gives 404 for CppTemplate.md url seems to be old https://osrf.github.io/mbari_wec/pr-preview/pr-53/Tutorials/ROS2/CPPTemplate.md. Even when I manually updated its still gives 404. Refreshing didn't work. Same with CppOpenLoopControl.md and ClosedLoopControl.md.

[andermi]

preview gives 404

Can you try again? It shows up fine for me:
https://osrf.github.io/mbari_wec/pr-preview/pr-53/Tutorials/ROS2/CppTemplate/

[andermi]

all the links work for me as well

[quarkytale]

Nope, tried it on another system too, the tutorial directs to CPPTemplate.md which gives the error and even if I manually change it to CppTemplate same error, something like this, enlarged content and 404 in the end:

[quarkytale]

Oh so when I try to go from the dropdown menu and click on Controller GitHub Template (C++) it creates a url with CPPTemplate.md but instead it should be CppTemplate/

[quarkytale]

I know what's wrong, you need to update mkdocs.yml as well to generate the correct navigation and links. Sorry I missed it in the review, all changes in tutorials.md should reflect in mkdocs.yml. I can make the quick change if you want.

[andermi]

pushed a fix, thanks

[quarkytale]

All good now, works for me!

[andermi]

I also just fixed a reference to ignition gazebo and other broken links