-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Docker image and minor fix for build script #47
Conversation
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
|
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Co-authored-by: andermi <anderson@mbari.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Okay, I've tested this. You should be able to follow the README to build with the new Docker image name ( Feel free to try out the instructions and push to DockerHub. We're not going to push a final image anyway until the logging feature is in. I've only tried the Note that by default, it builds the NVIDIA version. You can use |
Yet to try pushing to DockerHub but other things work fine |
Thanks! |
mbari_wec
to match DockerHub repoDo not tag with extra suffix (
_nvidia
|_no_nvidia
) if just building nvidia image.Previously, it mistakenly tagged the nvidia base image too, resulting in an extra tag like
nvidia_opengl_ubuntu22_nvidia
.The suffix was only meant for the main
buoy
image.