Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Docker image and minor fix for build script #47

Merged
merged 7 commits into from
Apr 14, 2023

Conversation

mabelzhang
Copy link
Collaborator

@mabelzhang mabelzhang commented Apr 10, 2023

  • Rename Docker image to mbari_wec to match DockerHub repo
  • Minor fix for build script:
    Do not tag with extra suffix (_nvidia | _no_nvidia) if just building nvidia image.
    Previously, it mistakenly tagged the nvidia base image too, resulting in an extra tag like nvidia_opengl_ubuntu22_nvidia.
    The suffix was only meant for the main buoy image.
  • Add instructions to README for pushing to DockerHub

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang requested a review from quarkytale April 10, 2023 16:21
@github-actions
Copy link

github-actions bot commented Apr 10, 2023

PR Preview Action 68cd47d
Preview removed because the pull request was closed.
2023-04-14 18:42 UTC

Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang mabelzhang linked an issue Apr 10, 2023 that may be closed by this pull request
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
docker/build.bash Outdated Show resolved Hide resolved
mabelzhang and others added 3 commits April 10, 2023 16:38
Co-authored-by: andermi <anderson@mbari.org>
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
@mabelzhang
Copy link
Collaborator Author

mabelzhang commented Apr 11, 2023

Okay, I've tested this. You should be able to follow the README to build with the new Docker image name (mbari_wec) and push to DockerHub.

Feel free to try out the instructions and push to DockerHub. We're not going to push a final image anyway until the logging feature is in.

I've only tried the run_simulation.bash, which just brings up the buoy simulation with ros2 launch buoy_gazebo mbari_wec.launch.py. Feel free to test other things in there, e.g. a tutorial, other features, to make sure it really works.

Note that by default, it builds the NVIDIA version. You can use --no-nvidia, but the graphics might be slow depending on what kind of graphics card you have.

@quarkytale
Copy link
Contributor

Yet to try pushing to DockerHub but other things work fine

@mabelzhang
Copy link
Collaborator Author

Thanks!

@mabelzhang mabelzhang merged commit 68cd47d into main Apr 14, 2023
@mabelzhang mabelzhang deleted the mabelzhang/fix_build_script branch April 14, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Host Docker image
3 participants