-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C++ Linear Damper Tutorial #43
Conversation
Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: andermi <bogfardps@gmail.com>
|
Co-authored-by: Dharini Dutia <dharini@openrobotics.org>
General comment on these tutorials - I've been noticing that at the top, the navigation goes from Home (an icon) directly to the individual "Quick Start -- ..." tutorials. Then if the user clicks on Home, they can't find how to go to other tutorials. I think we need to add a navigation list for the tutorials to this YAML file, maybe under the Line 10 in f53a957
one bullet per tutorial, so that the navigation bar will be like Home > Tutorials > "Quick Start -- ..." See https://www.mkdocs.org/user-guide/writing-your-docs/#configure-pages-and-navigation That should probably be done if we have any other subpages at level 3, so that the nav bar goes to level 2 first. Otherwise the default seems to just go from Home. This can be in a new PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. I'm impressed there are no English typos in this long page 😃
Co-authored-by: Mabel Zhang <mabel@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm since my review was requested - looks good to me, but I didn't read the code explanation closely - I think @quarkytale did that. My review was a high-level conceptual read and compiling and running it. Runs for me, buoy moves a bit faster than when it's not running, so I guess it works.
Yeah good to go from me too! Though I was still getting the linker error while compiling even on a fresh installation, if it worked for you then perfect, I'll debug my workspace. |
Refers to simple_interp |
tutorial: CppLinearDamperExample
example code: linear_damper_example