Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ Linear Damper Tutorial #43

Merged
merged 8 commits into from
Apr 10, 2023
Merged

C++ Linear Damper Tutorial #43

merged 8 commits into from
Apr 10, 2023

Conversation

andermi
Copy link
Collaborator

@andermi andermi commented Mar 30, 2023

andermi and others added 2 commits March 29, 2023 11:34
Signed-off-by: Michael Anderson <anderson@mbari.org>
Signed-off-by: andermi <bogfardps@gmail.com>
@github-actions
Copy link

github-actions bot commented Mar 30, 2023

PR Preview Action 6ac6d62
Preview removed because the pull request was closed.
2023-04-10 20:50 UTC

@andermi andermi linked an issue Mar 30, 2023 that may be closed by this pull request
4 tasks
@andermi andermi mentioned this pull request Mar 30, 2023
4 tasks
@andermi andermi requested a review from quarkytale April 7, 2023 01:45
@mabelzhang
Copy link
Collaborator

mabelzhang commented Apr 7, 2023

General comment on these tutorials - I've been noticing that at the top, the navigation goes from Home (an icon) directly to the individual "Quick Start -- ..." tutorials. Then if the user clicks on Home, they can't find how to go to other tutorials.

I think we need to add a navigation list for the tutorials to this YAML file, maybe under the Tutorials line:

- Tutorials: tutorials.md

one bullet per tutorial, so that the navigation bar will be like Home > Tutorials > "Quick Start -- ..."

See https://www.mkdocs.org/user-guide/writing-your-docs/#configure-pages-and-navigation

That should probably be done if we have any other subpages at level 3, so that the nav bar goes to level 2 first. Otherwise the default seems to just go from Home.

This can be in a new PR.

Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I'm impressed there are no English typos in this long page 😃

docs/docs/Tutorials/ROS2/CppLinearDamperExample.md Outdated Show resolved Hide resolved
docs/docs/Tutorials/ROS2/CppLinearDamperExample.md Outdated Show resolved Hide resolved
@andermi andermi requested a review from mabelzhang April 10, 2023 17:56
Copy link
Collaborator

@mabelzhang mabelzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm since my review was requested - looks good to me, but I didn't read the code explanation closely - I think @quarkytale did that. My review was a high-level conceptual read and compiling and running it. Runs for me, buoy moves a bit faster than when it's not running, so I guess it works.

@andermi andermi merged commit 6ac6d62 into main Apr 10, 2023
@andermi andermi deleted the andermi/cpp_linear_damper branch April 10, 2023 20:50
@quarkytale
Copy link
Contributor

Yeah good to go from me too! Though I was still getting the linker error while compiling even on a fresh installation, if it worked for you then perfect, I'll debug my workspace.

@mabelzhang
Copy link
Collaborator

mabelzhang commented Apr 10, 2023

linker error

Refers to simple_interp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Controller Tutorials
3 participants