Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting up Docker for buoy sim development #3

Merged
merged 12 commits into from
May 10, 2022
Merged

Setting up Docker for buoy sim development #3

merged 12 commits into from
May 10, 2022

Conversation

quarkytale
Copy link
Contributor

@quarkytale quarkytale commented Apr 18, 2022 •
edited
Loading

Introduction

Developing under docker container would help reproduce, find and fix issues quicker. Increases stability and reliability of the project.

Requirements

  1. Install Docker using installation instructions.
  2. Complete the Linux Postinstall steps to allow you to manage Docker as a non-root user.
  3. Install rocker by sudo apt-get install python3-rocker.

Usage

```
git clone https://github.com/osrf/buoy_entrypoint.git
cd ~/buoy_entrypoint/docker/
./build.bash buoy 
./run.bash [-d|s] buoy:latest
```

@quarkytale
build, run dockerfile for buoy
58404bf 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@quarkytale quarkytale requested a review from chapulina April 18, 2022 22:52
chapulina
chapulina reviewed Apr 19, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an initial high-level review

docker/build.bash Outdated Show resolved Hide resolved
docker/build.bash Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
@quarkytale
suggested edits and fixed user
44633f8 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@quarkytale
fixed project building and added run options
2dd2ef9 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@quarkytale quarkytale marked this pull request as ready for review April 20, 2022 23:28
chapulina
chapulina reviewed Apr 25, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working for me! Just some final comments.

docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
docker/run.bash Outdated Show resolved Hide resolved
docker/run.bash Outdated Show resolved Hide resolved
docker/run.bash Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docker/run.bash Outdated Show resolved Hide resolved
@quarkytale
commiting suggestions
c7ce40d 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@quarkytale
typo
367cdbe 
Signed-off-by: quarkytale <dharini@openrobotics.org>
chapulina
chapulina suggested changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still having some trouble running the image

README.md Outdated Show resolved Hide resolved
docker/buoy/Dockerfile Outdated Show resolved Hide resolved
quarkytale and others added 2 commits May 10, 2022 00:02
@quarkytale
fixing buoy_ws permissions
ba0bf19 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@chapulina
Suggestions to Docker
776fbd3 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request May 10, 2022
Merged
chapulina and others added 3 commits May 10, 2022 10:57
@chapulina
apt-utils
ab9f939
@quarkytale
Merge pull request #5 from osrf/chapulina/docker_suggestions
865f5d6 
Suggestions to Docker setup
@quarkytale
additional documentation
1b81e2e 
Signed-off-by: quarkytale <dharini@openrobotics.org>
@quarkytale quarkytale requested a review from chapulina May 10, 2022 20:22
@quarkytale
doc for development option
2a30488 
Signed-off-by: quarkytale <dharini@openrobotics.org>
chapulina
chapulina approved these changes May 10, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! LGTM!

@chapulina chapulina merged commit f8cf6f3 into main May 10, 2022
@chapulina chapulina deleted the quarkytale/docker branch May 10, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

Assignees

@quarkytale quarkytale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@quarkytale @chapulina