Switch to Humble/Garden on 22.04 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
|
|
will need to switch checkouts in the vcs yaml back to main after osrf/mbari_wec_gz#111 and osrf/mbari_wec_utils#38 are merged |
12 tasks
mabelzhang
reviewed
Jan 13, 2023
There was a problem hiding this comment.
Dockerfile built for me (once I replaced the buoy_all.yaml URL with the temporary file in this PR).
One comment for building from source. (The Dockerfile built without this because building from binaries sets up Python fine, but building from source needs a manual export I believe).
Will approve after the one change.
Signed-off-by: Michael Anderson <anderson@mbari.org>
mabelzhang
reviewed
Jan 20, 2023
mabelzhang
reviewed
Jan 20, 2023
|
Dockerfile addition? |
Signed-off-by: Michael Anderson <anderson@mbari.org>
…y_entrypoint into chapulina/humble_garden
|
updated |
mabelzhang
reviewed
Jan 21, 2023
Signed-off-by: Michael Anderson <anderson@mbari.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick review for github actions / ci