Rework lrauv test suite
#192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
- Export CMake targets for downstream usage - Add colcon hook equivalent for sh-like shells - Remove all tests Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
- Export CMake targets for downstream usage - Add colcon hook equivalent for sh-like shells - Remove all tests Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
This package aggregates all tests in this repository, plus a set of useful abstractions to ease reuse. Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Note for the reviewers: each commit affects a single package and thus it would be straightforward to split this PR if necessary. |
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
|
Alright, all tests are passing locally on this patch. I'll go ahead and split it while new MBARI images get built. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precisely what the title says. Following #189 and building on top of #187, this patch aggregates all tests in an
lrauv_system_testspackage downstream oflrauv_ignition_pluginsandlrauv_description. This package also includes useful abstractions, derived from existing test patterns, with which all tests have been reworked to reduce duplication and flakyness.All tests but mission tests have been verified to pass locally. Missions tests will be checked next (as custom MBARI configuration is required). A README.md for the
lrauv_system_testspackage summarizing #189 is yet to be added too.