Adds interpolation to the science sensor refactor #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently all our tests are failing because the garden tagged images were removed. This retargets the tests to use the latest tag. Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Requires igntionrobotics/ign-math#412 Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
hidmic
reviewed
Apr 25, 2022
| /// interp.index.value()] << "@" << interp.position << std::endl; | ||
| /// igndbg << "My distance is " << interp.position.X() - sphericalDepthCorrected.X() | ||
| /// << ", " << interp.position.Y() - sphericalDepthCorrected.Y() << std::endl; | ||
| /// } |
There was a problem hiding this comment.
@arjo129 debugging leftover?
Closed
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
…sor_interpolation Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
…sor_interpolation
Signed-off-by: Arjo Chakravarty <arjo@openrobotics.org>
hidmic
reviewed
Apr 27, 2022
| @@ -0,0 +1,195 @@ | |||
| /* | |||
There was a problem hiding this comment.
@arjo129 nit: would test_chlorophyll_sensor be a more accurate name for this test?
| for (auto &msg: received_msg) | ||
| { | ||
| EXPECT_TRUE(msg.load()); | ||
| } |
There was a problem hiding this comment.
@arjo129 meta: I'm good with moving forward with this as-is in the interest of time, but I'd suggest adding a TODO for a test overhaul using lrauv_system_tests support to avoid the races (and reduce total LOC count).
|
I'll rebase this. Seem to have messed it up |
hidmic
reviewed
Apr 27, 2022
| reinterpolate = true; | ||
| IGN_PROFILE("ScienceSensorsSystem::Interpolation"); | ||
| if (interpolators.size() == 0) return; | ||
| if (!interpolators[0].index.has_value()) return; |
There was a problem hiding this comment.
@arjo129 shall we set NaNs even when interpolation is not possible too?
| ignition::math::Temperature tempC; | ||
| tempC.SetCelsius(temp); | ||
| tempC.SetCelsius(temp.value()); |
There was a problem hiding this comment.
@arjo129 nit^N!: value_or() may be practical here to deduplicate some code.
hidmic
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires igntionrobotics/ign-math#412
Signed-off-by: Arjo Chakravarty arjo@openrobotics.org