Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use upstream's PointCloudPackedIterator #138

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Use upstream's PointCloudPackedIterator #138

merged 1 commit into from
Jan 24, 2022

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Jan 6, 2022 •
edited
Loading

I cherry-picked that PR into ign-msgs's chapulina/9/tmp_packed branch for Garden so this PR can be more easily tested. Upstream is available from main

@chapulina
Use upstream's PointCloudPackedIterator
575e532 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina mentioned this pull request Jan 6, 2022
Merged
@chapulina chapulina self-assigned this Jan 12, 2022
@chapulina chapulina added the needs upstream release Blocked by a release of an upstream library label Jan 12, 2022
@caguero caguero mentioned this pull request Jan 19, 2022
Closed
39 tasks
@caguero caguero added this to the 2022 M1 milestone Jan 19, 2022
@chapulina chapulina requested a review from caguero January 19, 2022 16:42
caguero
caguero reviewed Jan 20, 2022
View reviewed changes
Copy link
Collaborator

@caguero caguero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just waiting for CI to be happy when we release Ignition Msgs.

@chapulina
Copy link
Contributor Author

Just waiting for CI to be happy when we release Ignition Msgs.

Thanks! We just need forward ports and a nightly

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jan 20, 2022
@chapulina
Copy link
Contributor Author

CI is happy 🟢

@chapulina chapulina merged commit fd93e56 into main Jan 24, 2022
@chapulina chapulina deleted the chapulina/pc_packed branch January 24, 2022 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caguero caguero caguero approved these changes

Assignees

@chapulina chapulina

Labels
None yet
Projects
None yet
Milestone
2022 M1
Development

Successfully merging this pull request may close these issues.

Upstream point cloud utility functions
2 participants
@chapulina @caguero