Skip to content

Commit

Permalink
PR feedback
Browse files Browse the repository at this point in the history
Signed-off-by: Mabel Zhang <mabel@openrobotics.org>
  • Loading branch information
mabelzhang committed Jan 26, 2022
1 parent 0af6a57 commit feb33ed
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions lrauv_ignition_plugins/src/ScienceSensorsSystem.cc
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class tethys::ScienceSensorsSystemPrivate

/// \brief Create an octree from a point cloud, and search for _k nearest
/// neighbors.
/// \param[in] _searchPt Location in space to interpolate for
/// \param[in] _searchPt Location in space to search from
/// \param[in] _cloud Point cloud to search in
/// \param[out] _nbrInds Result of octree search, indices of points.
/// \param[out] _nbrSqrDists Result of octree search, distances.
Expand Down Expand Up @@ -728,6 +728,10 @@ void ScienceSensorsSystemPrivate::FindTrilinearInterpolators(
std::vector<pcl::PointXYZ> &_interpolators1,
std::vector<pcl::PointXYZ> &_interpolators2)
{
// Initialize return parameters
_interpolators1.clear();
_interpolators2.clear();

// Sanity checks
// Vector not populated
if (this->timeSpaceCoords.size() == 0)
Expand Down Expand Up @@ -851,7 +855,7 @@ void ScienceSensorsSystemPrivate::CreateDepthSlice(
bool _invert)
{
// Separate a z slice, i.e. points with z equal to that of 1st NN
// Pass in extract_removed_indices=true to get indices of removed points
// Pass in _invert=true to get indices of removed points
pcl::PassThrough<pcl::PointXYZ> passThruFilter =
pcl::PassThrough<pcl::PointXYZ>(true);
passThruFilter.setInputCloud(_cloud.makeShared());
Expand Down

0 comments on commit feb33ed

Please sign in to comment.