Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the "new release" issue template #7607

Merged
merged 4 commits into from
May 28, 2022
Merged

Update the "new release" issue template #7607

merged 4 commits into from
May 28, 2022

Conversation

mike-myers-tob
Copy link
Member

This PR just updates the "New Release" issue template, specifically because we no longer post new tagged release binaries to Slack. They become available on the Releases page as build artifacts.

That change was mine. Then GitHub has updated the other templates with some additional hidden fields.

@mike-myers-tob mike-myers-tob added ready for review Pull requests that are ready to be reviewed by a maintainer documentation development labels May 26, 2022
@mike-myers-tob mike-myers-tob requested review from a team as code owners May 26, 2022 00:37
directionless
directionless reviewed May 27, 2022
View reviewed changes
Copy link
Member

@directionless directionless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, it seems awkward as a template. Maybe better as a doc. But I think I suggested the correct corrections

mike-myers-tob and others added 2 commits May 26, 2022 22:43
@mike-myers-tob @directionless
Update .github/ISSUE_TEMPLATE/New_Release.md
83a0383 
Co-authored-by: seph <seph@kolide.co>
@mike-myers-tob @directionless
Update .github/ISSUE_TEMPLATE/New_Release.md
a9fcca3 
Co-authored-by: seph <seph@kolide.co>
@mike-myers-tob
Copy link
Member Author

Honestly, it seems awkward as a template. Maybe better as a doc. But I think I suggested the correct corrections

Good additions, thank you 👍🏻

@mike-myers-tob mike-myers-tob merged commit 8c22f40 into osquery:master May 28, 2022
@mike-myers-tob mike-myers-tob deleted the mike/revise-New-Release-Issue-Template branch May 28, 2022 02:55
@mike-myers-tob mike-myers-tob removed the ready for review Pull requests that are ready to be reviewed by a maintainer label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@directionless directionless directionless approved these changes

Assignees
No one assigned
Labels
development documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mike-myers-tob @directionless