Add patch for apache/thrift#2083 #6846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excellent. Yes this captures the change that adds what we need currently for issue #6798 I double checked that there are no additional commits we need to either of these files in the time between this patch and today. This branch builds for me on Windows 10 / VS 2019, and apparently all the CI runners, so I think it's good. Also I did some light testing with Trail of Bits' extensions on Windows, which still work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a patch for apache/thrift#2083 to our v0.13.0 checkout of apache/thrift. We intend to use these changes to set proper security descriptors for named pipes on Windows.
Heads up @mike-myers-tob