Restore PIE support being dropped on Linux #6611
Merged
+16
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMake ignores the sysroot when testing the support of PIE, so the link test fails when it tries to check for PIE support and decides that it's not supported. Therefore we tell CMake that PIE is supported when using the osquery-toolchain and leave the automatic test for other toolchains. Temporarily disable PIE on executables built with the osquery-toolchain libFuzzer, since it has not been compiled with PIE/PIC support.
theopolis
approved these changes
Aug 27, 2020
nabilschear
pushed a commit
to nabilschear/osquery
that referenced
this pull request
Aug 31, 2020
CMake ignores the sysroot when testing the support of PIE, so the link test fails when it tries to check for PIE support and decides that it's not supported. Therefore we tell CMake that PIE is supported when using the osquery-toolchain and leave the automatic test for other toolchains. Temporarily disable PIE on executables built with the osquery-toolchain libFuzzer, since it has not been compiled with PIE/PIC support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake ignores the sysroot when testing the support of PIE,
so the link test fails when it tries to check for PIE support
and decides that it's not supported.
Therefore we tell CMake that PIE is supported when using the
osquery-toolchain and leave the automatic test for other toolchains.
Temporarily disable PIE on executables built with the
osquery-toolchain libFuzzer, since it has not been compiled with PIE/PIC
support.