-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix pip upgrade warning #6576
Conversation
Something I failed to mention in the past: I have configured Azure Pipelines to build master every 4 hours, to be able (if looking at it!) to catch these kind of failures earlier, or at least see if they were repeatable. |
@Smjert, this fixes the issue but it may not be the only (or best) method. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine, if potentially slow. Dunno if you want to wait for @Smjert for it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this!
I did some tests and noticed that the situation changed when they updated the agent image version.
Python went from 3.8.4 to 3.8.5 but I don't think this is the issue because the warning about pip was already showing previously (although it's true that it's a NativeCommandError...).
Moreover I tested in a local VM with both Python versions, either directly inside powershell shell or a script and the process, despite the warning, never fails.
They must've changed something in the powershell task or in the powershell configuration.
The powershell task has a failOnStdErr
that should have the task fail if something is written to stderr, although by default it's at false.
I tried on my Azure Pipeline instance to explicitly set it to false, but the failure is still there.
Long story short there's something strange going on, but I think we can wait to maybe better look into it; meanwhile this is a valid workaround, and it doesn't seem to slow down much, if at all.
Pip is warning us that a newer version is available.
One solution is to upgrade
pip
before using it.