-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tables: Remove INDEX requirement for ADDITIONAL option #6104
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable. Feels this is very much a choice of the underlying implementation
Yeah, I’m going to take time and review the virtual table code again to make sure this does not have side effects. |
IIRC tables that have the ADDITIONAL option should not implement ROWID. |
How many table implement rowid anyhow? |
We do not need an explicit INDEX column for ADDITIONAL to work. If the ADDITIONAL option is set the constraint should be passed into the virtual table context.
4e83e0c
to
411ce2e
Compare
All tables without a column marked Tables without a defined primary key, and an |
411ce2e
to
fa33df3
Compare
fa33df3
to
447e027
Compare
In lieu of deeper docs, from today's office hours: The intent of #6104 is to start cleaning this up. We think:
And for primary keys:
A good example of how this plays out, is the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems okay? I did not build/test though
We do not need an explicit INDEX column for ADDITIONAL to work. If the ADDITIONAL option is set the constraint should be passed into the virtual table context.