Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs #132

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update Docs #132

wants to merge 7 commits into from

Conversation

abhijeetSaroha
Copy link
Collaborator

Solves #80

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB


---

### Benefit
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redundant section

```yaml
tasks:
greet:
help: Print a greeting
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add also the args section for this example

compile:
hooks:
pre-run:
- task: clean
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to the example the post-run hook.

also the name of the task should be in the format <group>.<task>, when it is called inside the hooks.

daily-clean:
task: build.clean
schedule: "0 0 * * *"
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add some commands with the cron/scheduler


If you need to deploy a project to a remote server:

```yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the config file here is not necessary.
you can point just to the spec documentation, something like:

If you want more details about Remote Execution, please check the spec documentation (and the link for the documentation).

it is similar to ansible or fabric (add links to that as well)

https://docs.ansible.com/
https://www.fabfile.org/

using YAML instead of Makefiles, it makes task definition more readable and
maintainable, improving developer productivity and CI/CD efficiency.

Start using Makim today to streamline your project automation!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line can be removed

```yaml
hooks:
pre-run:
- task: <task_name>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add into the spec and example the entry for if

env:
API_KEY: abc123
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a note at the end, the value should be always a string.
if the developer needs to pass an integer, it should be between quotes.

- 3.10
os:
- ubuntu
- macos]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- macos]
- macos


### Description

Defines scheduled tasks using cron syntax.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a link for more details about cron syntax

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add also an explanation for the cron syntax

host: example.com
port: 22
```

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -0,0 +1,264 @@
# Makim Specification
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is missing more details about vars, and env-file.

also for each item/topic, state what scopes is supported by that yaml entry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants