refactor: hide composition view on input view detached from window

This is the more accurate time to do so.
osfans · Jul 22, 2024 · 0555fe2 · 0555fe2
1 parent 34b59c4
commit 0555fe2
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/app/src/main/java/com/osfans/trime/ime/core/InputView.kt b/app/src/main/java/com/osfans/trime/ime/core/InputView.kt
@@ -385,6 +385,7 @@ class InputView(
     override fun onDetachedFromWindow() {
         ViewCompat.setOnApplyWindowInsetsListener(this, null)
         showingDialog?.dismiss()
+        composition.hideCompositionView()
         // cancel the notification job and clear all broadcast receivers,
         // implies that InputView should not be attached again after detached.
         notificationHandlerJob.cancel()

diff --git a/app/src/main/java/com/osfans/trime/ime/core/TrimeInputMethodService.kt b/app/src/main/java/com/osfans/trime/ime/core/TrimeInputMethodService.kt
@@ -319,7 +319,6 @@ open class TrimeInputMethodService : LifecycleInputMethodService() {
      *
      * 重置鍵盤、候選條、狀態欄等 !!注意，如果其中調用Rime.setOption，切換方案會卡住  */
     fun recreateInputView() {
-        inputView?.composition?.hideCompositionView()
         inputView = InputView(this, rime)
         mainKeyboardView = inputView!!.keyboardWindow.oldMainInputView.mainKeyboardView