Serialization Refactor #4162
Draft
Serialization Refactor #4162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02b2191 to
d758fad
Compare
lkastner
previously approved these changes
Nov 20, 2024
47e3f3f to
66a5f2e
Compare
lgoettgens
reviewed
Feb 7, 2025
Co-authored-by: Lars Göttgens <lars.goettgens@rwth-aachen.de>
* Use `grading_group` for `MPolyDecRing` * Fix some formatting * Some progress * Fix loading AbstractLieAlgebra * LinearLieAlgebras working * Modules working * Attrs are handled centrally now * Root system data working * Module construction data works * DirectSumLieAlgebras work * oops * Run formatter * Reduce diff
|
closes #4567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor serialization to use a new function called
type_paramswhich helps build a stack of type dependencies which will allow for serializing type information before the data.