Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable caching of julia modules in julia module storage #1045

Closed
wants to merge 4 commits into from
Closed

Disable caching of julia modules in julia module storage #1045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c351e6c
Disable caching of julia modules in julia module storage
lgoettgens Sep 19, 2024
d9b2abb
Add test
lgoettgens Sep 19, 2024
3c699ee
Merge branch 'master' into lg/module
lgoettgens Sep 20, 2024
fcceba2
Merge branch 'master' into lg/module
lgoettgens Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/JuliaInterface/gap/JuliaInterface.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ InstallMethod( \.,
var := _WrapJuliaFunction( var );
elif _JULIA_ISA( var, _JULIA_MODULE_TYPE ) then
var := _WrapJuliaModule( rnam, var );
\.\:\=( module!.storage, rnum, var );
fi;

return var;
Expand Down
10 changes: 10 additions & 0 deletions pkg/JuliaInterface/tst/utils.tst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,15 @@ gap> path:= GetJuliaScratchspace( "test_scratch" );;
gap> IsDirectoryPath( path );
true

# Julia modules should not get cached, see #1044
gap> JuliaEvalString("module foo x = 1 end");
<Julia: Main.foo>
gap> Julia.foo.x;
1
gap> JuliaEvalString("module foo x = 2 end");
<Julia: Main.foo>
gap> Julia.foo.x;
2

##
gap> STOP_TEST( "utils.tst" );
Loading