image: add support for FIPS customization to BootcDiskImage
#1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit is a followup for osbuild/bootc-image-builder#709 and adds support for FIPS to the `BootcDiskImage` image type. One open question is if this should be done at this level or if the container itself should set the kernel cmdline to FIPS and bib would not bother.
|
I don't think this is neccessary, the |
|
Excellent, less work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as I think we want to double check if this makes sense in the bootc world first]
This commit is a followup for
osbuild/bootc-image-builder#709 and adds support for FIPS to the
BootcDiskImageimage type.One open question is if this should be done at this level or if the container itself should set the kernel cmdline to FIPS and bib would not bother.