Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Remove deprecated selects #2903

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

regexowl
Copy link
Collaborator

This swaps deprecated PF4 selects for non-deprecated PF5 ones in few places.

@regexowl regexowl force-pushed the remove-deprecated-selects branch from 6ff7990 to 27e5d48 Compare February 17, 2025 09:01
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 98.59155% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.12%. Comparing base (0c8b6b3) to head (e10546a).

Files with missing lines Patch % Lines
...teImageWizard/steps/FileSystem/FileSystemTable.tsx 98.07% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2903      +/-   ##
==========================================
+ Coverage   82.09%   82.12%   +0.03%     
==========================================
  Files         207      207              
  Lines       23293    23339      +46     
  Branches     2286     2287       +1     
==========================================
+ Hits        19122    19167      +45     
- Misses       4144     4145       +1     
  Partials       27       27              
Files with missing lines Coverage Δ
...CreateImageWizard/steps/ImageOutput/ArchSelect.tsx 96.66% <100.00%> (+0.83%) ⬆️
...teImageWizard/steps/FileSystem/FileSystemTable.tsx 73.30% <98.07%> (+2.13%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c8b6b3...e10546a. Read the comment docs.

@regexowl regexowl marked this pull request as ready for review February 17, 2025 15:15
@regexowl regexowl force-pushed the remove-deprecated-selects branch from 27e5d48 to caafd1b Compare February 17, 2025 15:16
@regexowl
Copy link
Collaborator Author

/retest

@regexowl regexowl marked this pull request as draft February 18, 2025 09:44
@regexowl regexowl marked this pull request as ready for review February 18, 2025 09:59
This replaces deprecated PF4 select with non-deprecated PF5 one.
This swaps deprecated PF4 Selects on FSC step for non-deprecated PF5 ones.
@regexowl regexowl force-pushed the remove-deprecated-selects branch from caafd1b to e10546a Compare February 18, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant