-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Switch view to "Available" when searching for package (HMS-5480) #2873
base: main
Are you sure you want to change the base?
Conversation
/jira-epic HMS-5294 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for taking this one!
Would you mind getting the tests passing?
e39a94c
to
aa0fc37
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #2873 +/- ##
=======================================
Coverage 82.14% 82.14%
=======================================
Files 207 207
Lines 23220 23221 +1
Branches 2270 2270
=======================================
+ Hits 19074 19075 +1
Misses 4119 4119
Partials 27 27
Continue to review full report in Codecov by Sentry.
|
b458bef
to
4dbe2d4
Compare
after this small change - setToggleSelected('toggle-available');
and now there are 3 tests that failing, and it is very wired, Screen.Recording.2025-02-11.at.17.54.28.movI think this is a bug in the mock data, I couldnt reproduce that manully @lucasgarfield need your advice here for now I fixed the failing tests respectivally to the bug in the mock, but maybe you will have different approach here |
94f075a
to
0e1d790
Compare
Ah nice! The problem with the tests suddenly makes sense after noticing it should sort selected packages 😅 but that brings a question - aren't we losing the option to sort through those? Imagine a situation where you have one hundred selected packages. And you want to know if |
While I understand the concern about losing the ability to filter within the 'Selected' tab, my belief is that user primarily initiates a search when he intend to add new packages. User familiar with his current selections would likely navigate directly to the 'Selected' tab for review, rather than using search to locate specific items within that list. |
this fix an issue when user search for a package, the viewv stay "Selected" instead of switching to "Available fix one test
this fix an issue when user search for a package, the viewv stay "Selected" instead of switching to "Available
FIX ISSUE: (#2864)
JIRA: HMS-5480