Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cockpit/spec: add obsoletes & fix release workflow #2863

Merged
merged 3 commits into from
Feb 7, 2025

Conversation

croissanne
Copy link
Member

With #2862 moving the artefact out of the checkout dir got reverted.

Adds an obsoletes for cockpit-composer.

@croissanne croissanne requested a review from thozza February 7, 2025 10:01
thozza
thozza previously approved these changes Feb 7, 2025
Copy link
Member

@thozza thozza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Looking at the diff made me wonder if the minimum required osbuild-composer version is correct? Since you mentioned that you've been waiting for the package search functionality which landed just recently.

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.14%. Comparing base (e74675a) to head (4e3a05f).
Report is 4 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2863   +/-   ##
=======================================
  Coverage   82.14%   82.14%           
=======================================
  Files         207      207           
  Lines       23181    23181           
  Branches     2274     2273    -1     
=======================================
  Hits        19042    19042           
  Misses       4112     4112           
  Partials       27       27           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a03a259...4e3a05f. Read the comment docs.

@croissanne
Copy link
Member Author

LGTM. Looking at the diff made me wonder if the minimum required osbuild-composer version is correct? Since you mentioned that you've been waiting for the package search functionality which landed just recently.

oh good point, let me fix that

Package search was only added recently.

 Requires:       cockpit
 Requires:       cockpit-files
-Requires:       osbuild-composer >= 103
+Requires:       osbuild-composer >= 131

 %description
 The image-builder-frontend generates custom images suitable for
@croissanne croissanne merged commit 5b62598 into osbuild:main Feb 7, 2025
19 of 20 checks passed
@croissanne croissanne deleted the obsoletes branch February 7, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants