Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockpit plugin: enable all customizations and implement updating blueprints (HMS-5459) #2848

Merged
merged 7 commits into from
Feb 5, 2025
Merged

cockpit plugin: enable all customizations and implement updating blueprints (HMS-5459) #2848

merged 7 commits into from
Feb 5, 2025

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Feb 4, 2025 •
edited
Loading

Adds all the new customizations, and implements updating blueprints.

cockpit-ib-.3.mp4

JIRA: HMS-5459

@croissanne croissanne force-pushed the more-customizations-and-update branch from b4aa3ec to 97e1130 Compare February 4, 2025 22:10
@croissanne croissanne marked this pull request as ready for review February 4, 2025 22:10
@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 28.98551% with 49 lines in your changes missing coverage. Please review.

Project coverage is 82.55%. Comparing base (3e542a6) to head (e0eb25b).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
src/store/cockpit/enhancedCockpitApi.ts 20.83% 19 Missing ⚠️
src/store/cockpit/cockpitApi.ts 25.00% 15 Missing ⚠️
src/Utilities/useGetEnvironment.ts 14.28% 12 Missing ⚠️
...ueprints/helpers/onPremToHostedBlueprintMapper.tsx 0.00% 1 Missing ⚠️
src/store/backendApi.ts 66.66% 1 Missing ⚠️
src/store/wizardSlice.ts 66.66% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2848      +/-   ##
==========================================
- Coverage   82.73%   82.55%   -0.19%     
==========================================
  Files         202      202              
  Lines       22887    22943      +56     
  Branches     2258     2259       +1     
==========================================
+ Hits        18936    18941       +5     
- Misses       3927     3978      +51     
  Partials       24       24
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 97.07% <100.00%> (ø)
...teImageWizard/steps/Review/Footer/EditDropdown.tsx 55.22% <ø> (ø)
...s/CreateImageWizard/steps/Review/Footer/Footer.tsx 97.11% <100.00%> (-0.03%) ⬇️
src/Components/CreateImageWizard/validators.ts 94.01% <100.00%> (ø)
...ueprints/helpers/onPremToHostedBlueprintMapper.tsx 45.90% <0.00%> (+0.24%) ⬆️
src/store/backendApi.ts 67.44% <66.66%> (-0.06%) ⬇️
src/store/wizardSlice.ts 86.96% <66.66%> (-0.09%) ⬇️
src/Utilities/useGetEnvironment.ts 51.42% <14.28%> (-23.58%) ⬇️
src/store/cockpit/cockpitApi.ts 17.05% <25.00%> (+0.47%) ⬆️
src/store/cockpit/enhancedCockpitApi.ts 40.84% <20.83%> (-11.24%) ⬇️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e542a6...e0eb25b. Read the comment docs.

@croissanne croissanne force-pushed the more-customizations-and-update branch from 97e1130 to 59b1481 Compare February 5, 2025 10:41
@croissanne
Copy link
Member Author

/jira-epic COMPOSER-2411

@schutzbot schutzbot changed the title cockpit plugin: enable all customizations and implement updating blueprints cockpit plugin: enable all customizations and implement updating blueprints (HMS-5459) Feb 5, 2025
@croissanne croissanne force-pushed the more-customizations-and-update branch from 59b1481 to f03ef37 Compare February 5, 2025 10:55
@croissanne
Utilities/useGetEnvironment: support feature flags on prem
17895ee 
These are just hardcoded, but enable the new customizations in the on
premise UI.
@croissanne
store/wizardSlice: default to 'register-later' when on-premise
9e3630a
@croissanne
CreateImageWizard: support edit mode on premise
c043621 
The way the on premise wizard is initialized needed to be tweaked to
make it work for isEdit. Let's assume that the host distro and host
architecture are already correct in the blueprint.
@croissanne
store/cockpitApi: fix deleting blueprints
a8b6829
@croissanne
CreateImageWizard: fix systemd validator
216c89c 
The naming of systemd services don't follow the RFC in the comments. See
`man systemd.unit` for the specification.
@croissanne
Blueprints/helpers: fix mapping hosted to on prem
b36ff4e 
`isAdministrator` isn't an option onPrem.
@croissanne
store/cockpitApi: add notification when composing images
e0eb25b
@croissanne croissanne force-pushed the more-customizations-and-update branch from f03ef37 to e0eb25b Compare February 5, 2025 10:59
@croissanne
Copy link
Member Author

fedora-42 is broken due to the forking of rawhide.

kingsleyzissou
kingsleyzissou approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

regexowl
regexowl reviewed Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test, but code looks good. One question

src/Components/Blueprints/helpers/onPremToHostedBlueprintMapper.tsx Show resolved Hide resolved
@regexowl
Copy link
Collaborator

regexowl commented Feb 5, 2025 •
edited
Loading

The check failures are expected, merging manually

@regexowl regexowl merged commit 76044dd into osbuild:main Feb 5, 2025
17 of 21 checks passed
@croissanne croissanne deleted the more-customizations-and-update branch February 5, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingsleyzissou kingsleyzissou kingsleyzissou approved these changes

@regexowl regexowl regexowl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@croissanne @regexowl @kingsleyzissou