Composer service (HMS-5455) #2847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2847 +/- ##
==========================================
- Coverage 83.04% 82.73% -0.31%
==========================================
Files 200 202 +2
Lines 22802 22887 +85
Branches 2256 2258 +2
==========================================
Hits 18936 18936
- Misses 3844 3927 +83
- Partials 22 24 +2
Continue to review full report in Codecov by Sentry.
|
croissanne
requested changes
Feb 4, 2025
croissanne
approved these changes
Feb 4, 2025
croissanne
reviewed
Feb 4, 2025
Add a component to display when the osbuild-composer socket is not running. We could potentially try start the socket in the future when clicking the button, rather than re-directing to the cockpit services plugin.
Add a custom hook to check to see if the osbuild-composer.socket is enabled & running.
Render the nont ready component when the osbuild-composer.socket is not running.
Add a secondary button that takes the user to the `osbuild-composer.socket` services file inside the cockpit services plugin.
7cd41b7 to
e017587
Compare
croissanne
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
osbuild-composer.socketosbuild-composer.socketif the unit is disabled/not activeScreen.Recording.2025-02-04.at.16.02.12.mov
/jira-epic COMPOSER-2411
JIRA: HMS-5455