Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard: Add validation to ChippingInput (HMS-5446) #2837

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Feb 4, 2025

This adds step validation to ChippingInput, allowing to validate imported values.

JIRA: HMS-5446

@regexowl
Copy link
Collaborator Author

regexowl commented Feb 4, 2025

/jira-epic HMS-5294

This adds step validation to ChippingInput, allowing to validate imported values.
@schutzbot schutzbot changed the title Wizard: Add validation to ChippingInput Wizard: Add validation to ChippingInput (HMS-5446) Feb 4, 2025
@regexowl regexowl force-pushed the step-validation-chipping-input branch from 476fd56 to c43d13b Compare February 4, 2025 09:56
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 75.80645% with 30 lines in your changes missing coverage. Please review.

Project coverage is 82.90%. Comparing base (6ec433f) to head (c43d13b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ents/CreateImageWizard/utilities/useValidation.tsx 64.28% 30 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2837      +/-   ##
==========================================
- Coverage   82.95%   82.90%   -0.05%     
==========================================
  Files         199      199              
  Lines       22402    22517     +115     
  Branches     2184     2210      +26     
==========================================
+ Hits        18583    18668      +85     
- Misses       3797     3827      +30     
  Partials       22       22              
Files with missing lines Coverage Δ
src/Components/CreateImageWizard/ChippingInput.tsx 100.00% <100.00%> (ø)
...Components/CreateImageWizard/CreateImageWizard.tsx 97.03% <100.00%> (+0.06%) ⬆️
...ageWizard/steps/Firewall/components/PortsInput.tsx 100.00% <100.00%> (ø)
...ImageWizard/steps/Firewall/components/Services.tsx 100.00% <100.00%> (ø)
...Wizard/steps/Kernel/components/KernelArguments.tsx 100.00% <100.00%> (ø)
...zard/steps/Timezone/components/NtpServersInput.tsx 100.00% <100.00%> (ø)
src/Components/CreateImageWizard/validators.ts 93.80% <100.00%> (ø)
...ents/CreateImageWizard/utilities/useValidation.tsx 87.90% <64.28%> (-10.07%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ec433f...c43d13b. Read the comment docs.

Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perf!

@regexowl regexowl merged commit f11ab64 into osbuild:main Feb 4, 2025
16 of 18 checks passed
@regexowl regexowl deleted the step-validation-chipping-input branch February 4, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants