Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cockpit-files for local targets (HMS-5422) #2820

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Use cockpit-files for local targets (HMS-5422) #2820

merged 2 commits into from
Jan 31, 2025

Conversation

croissanne
Copy link
Member

@croissanne croissanne commented Jan 30, 2025 •
edited by schutzbot
Loading

cockpit-ib-.2.mp4

/jira-epic COMPOSER-2411

JIRA: HMS-5422

@schutzbot schutzbot changed the title Use cockpit-files for local targets Use cockpit-files for local targets (HMS-5422) Jan 30, 2025
@croissanne croissanne force-pushed the local-target-file-browser branch from c83cab1 to caaa1b1 Compare January 30, 2025 21:39
@croissanne
ImagesTable/Instance: open cockpit's file browser for local imgs
1df17e1 
Uses `cockpit.jump` to prevent the page actually loading, which makes it
very easy to navigate back to image builder.
@croissanne
cockpit/spec: depend on cockpit-files
5dc1ac1
@croissanne croissanne force-pushed the local-target-file-browser branch from caaa1b1 to 5dc1ac1 Compare January 30, 2025 21:39
@codecov Codecov
Copy link

codecov bot commented Jan 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 21.05263% with 15 lines in your changes missing coverage. Please review.

Project coverage is 83.17%. Comparing base (1f5afc6) to head (5dc1ac1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/Components/ImagesTable/Instance.tsx 0.00% 15 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2820      +/-   ##
==========================================
- Coverage   83.22%   83.17%   -0.05%     
==========================================
  Files         190      190              
  Lines       22215    22233      +18     
  Branches     2174     2174              
==========================================
+ Hits        18488    18492       +4     
- Misses       3705     3719      +14     
  Partials       22       22
Files with missing lines Coverage Δ
src/test/mocks/cockpit/index.ts 25.64% <100.00%> (+8.49%) ⬆️
src/Components/ImagesTable/Instance.tsx 47.17% <0.00%> (-2.31%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f5afc6...5dc1ac1. Read the comment docs.

kingsleyzissou
kingsleyzissou approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@kingsleyzissou kingsleyzissou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! This is amazing, such a nice touch

@croissanne
Copy link
Member Author

/retest

@croissanne croissanne merged commit e249558 into osbuild:main Jan 31, 2025
16 of 18 checks passed
@croissanne croissanne deleted the local-target-file-browser branch January 31, 2025 10:38
@croissanne croissanne mentioned this pull request Feb 3, 2025
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingsleyzissou kingsleyzissou kingsleyzissou approved these changes

@lucasgarfield lucasgarfield Awaiting requested review from lucasgarfield

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@croissanne @kingsleyzissou