Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockpit: make CreateImageWizard functional (HMS-5408) #2780

Merged
merged 4 commits into from
Jan 28, 2025
Merged

cockpit: make CreateImageWizard functional (HMS-5408) #2780

merged 4 commits into from
Jan 28, 2025

Conversation

kingsleyzissou
Copy link
Collaborator

@kingsleyzissou kingsleyzissou commented Jan 21, 2025 •
edited by schutzbot
Loading

This PR makes it possible to step through each step of the CreateImageWizard and make the wizard functional.
It is a follow up to #2735. The actual blueprint creation will be done in a follow up PR.

/jira-epic COMPOSER-2411

JIRA: HMS-5408

@kingsleyzissou kingsleyzissou force-pushed the cockpit_create branch 2 times, most recently from 78d918f to bc12708 Compare January 23, 2025 15:15
@croissanne croissanne mentioned this pull request Jan 27, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Jan 27, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 54.54545% with 25 lines in your changes missing coverage. Please review.

Project coverage is 84.54%. Comparing base (e34ed8c) to head (7372524).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/store/cockpitApi.ts 41.66% 14 Missing ⚠️
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 50.00% 8 Missing ⚠️
src/store/backendApi.ts 66.66% 2 Missing ⚠️
...s/CreateImageWizard/steps/Review/Footer/Footer.tsx 88.88% 1 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
- Coverage   84.60%   84.54%   -0.07%     
==========================================
  Files         189      189              
  Lines       21675    21713      +38     
  Branches     2156     2159       +3     
==========================================
+ Hits        18339    18358      +19     
- Misses       3314     3333      +19     
  Partials       22       22
Files with missing lines Coverage Δ
...teImageWizard/steps/Review/ReviewStepTextLists.tsx 94.94% <ø> (ø)
...s/CreateImageWizard/steps/Review/Footer/Footer.tsx 97.14% <88.88%> (-0.88%) ⬇️
src/store/backendApi.ts 67.74% <66.66%> (-0.26%) ⬇️
...ImageWizard/steps/Review/Footer/CreateDropdown.tsx 67.93% <50.00%> (-0.57%) ⬇️
src/store/cockpitApi.ts 24.86% <41.66%> (+2.56%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e34ed8c...7372524. Read the comment docs.

croissanne
croissanne approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

src/store/cockpitApi.ts Show resolved Hide resolved
@croissanne
Copy link
Member

/retest

@kingsleyzissou kingsleyzissou marked this pull request as ready for review January 28, 2025 09:54
@kingsleyzissou kingsleyzissou changed the title [WIP] cockpit create blueprint cockpit: create blueprint Jan 28, 2025
@kingsleyzissou kingsleyzissou changed the title cockpit: create blueprint cockpit: make CreateImageWizard functional Jan 28, 2025
@schutzbot schutzbot changed the title cockpit: make CreateImageWizard functional cockpit: make CreateImageWizard functional (HMS-5407) Jan 28, 2025
@schutzbot schutzbot changed the title cockpit: make CreateImageWizard functional (HMS-5407) cockpit: make CreateImageWizard functional (HMS-5408) Jan 28, 2025
@kingsleyzissou
CreateImageWizard: disable analytics for on-prem
c2abc3d
@kingsleyzissou
CreateImageWizard: ignore org-id for on-prem
cb520bf 
We can ignore the org-id when trying to get the state of the
blueprint during the blueprint creation. This is unnecessary
info for `on-prem`
@kingsleyzissou
store/cockpitApi: add list snapshot mutation
94e89b0 
This is not ideal, but we needed to add an empty endpoint for
this, even though we're ignoring it on prem. The frontend for
the service makes the api call regardless, so we can't ignore
this.
@kingsleyzissou
store/cockpitApi: add create blueprint mutation
7372524
@croissanne
Copy link
Member

/retest

@croissanne croissanne enabled auto-merge (rebase) January 28, 2025 11:41
@croissanne croissanne disabled auto-merge January 28, 2025 12:29
@croissanne croissanne merged commit 94f24ce into osbuild:main Jan 28, 2025
16 of 19 checks passed
@kingsleyzissou kingsleyzissou deleted the cockpit_create branch January 28, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croissanne croissanne croissanne approved these changes

Assignees
No one assigned
Labels
🌟 best practice
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kingsleyzissou @croissanne @schutzbot