Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint: Disable autofix for "no-unnecessary-condition" (HMS-5374) #2772

Merged

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 20, 2025

This disables autofix specifically for the "no-unnecessary-condition" rule. This allows us to continue using autofix without applying the breaking changes.

JIRA: HMS-5374

@regexowl regexowl force-pushed the disable-autofix-for-no-unnecessary-condition branch from 16cfd89 to 5e732a6 Compare January 21, 2025 12:34
@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5173

@schutzbot schutzbot changed the title ESLint: Disable autofix for "no-unnecessary-condition" ESLint: Disable autofix for "no-unnecessary-condition" (HMS-5374) Jan 22, 2025
This disables autofix specifically for the "no-unnecessary-condition" rule. This allows us to continue using autofix without applying the breaking changes.
@croissanne croissanne force-pushed the disable-autofix-for-no-unnecessary-condition branch from 5e732a6 to 85afec3 Compare January 22, 2025 12:32
@regexowl regexowl enabled auto-merge (rebase) January 22, 2025 12:34
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (d41c079) to head (85afec3).
Report is 1 commits behind head on main.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2772   +/-   ##
=======================================
  Coverage   84.73%   84.73%           
=======================================
  Files         186      186           
  Lines       21248    21248           
  Branches     2087     2087           
=======================================
  Hits        18005    18005           
  Misses       3221     3221           
  Partials       22       22           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41c079...85afec3. Read the comment docs.

@regexowl regexowl merged commit 692ba3d into osbuild:main Jan 22, 2025
17 of 18 checks passed
@regexowl regexowl deleted the disable-autofix-for-no-unnecessary-condition branch January 22, 2025 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants