Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

validators: Remove undefined where only string value expected (HMS-5354) #2754

Merged
merged 1 commit into from
Jan 20, 2025
Merged

validators: Remove undefined where only string value expected (HMS-5354) #2754

merged 1 commit into from
Jan 20, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 16, 2025 •
edited by schutzbot
Loading

This removes checks for an undefined value in validators that take only string.

JIRA: HMS-5354

@codecov Codecov
Copy link

codecov bot commented Jan 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.66%. Comparing base (563ff04) to head (91bbdaa).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2754      +/-   ##
==========================================
- Coverage   84.66%   84.66%   -0.01%     
==========================================
  Files         186      186              
  Lines       21008    20999       -9     
  Branches     2035     2035              
==========================================
- Hits        17787    17778       -9     
  Misses       3199     3199              
  Partials       22       22
Files with missing lines Coverage Δ
src/Components/CreateImageWizard/validators.ts 93.42% <100.00%> (-0.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 563ff04...91bbdaa. Read the comment docs.

@regexowl regexowl force-pushed the update-validators branch 2 times, most recently from ff648dc to 31a03e1 Compare January 17, 2025 15:33
@regexowl regexowl requested a review from mgold1234 January 20, 2025 09:23
mgold1234
mgold1234 approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@mgold1234 mgold1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@regexowl
validators: Remove undefined where only string value expected
91bbdaa 
This removes checks for an `undefined` value in validators that take only `string`.
@regexowl regexowl enabled auto-merge (rebase) January 20, 2025 11:47
@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5173

@schutzbot schutzbot changed the title validators: Remove undefined where only string value expected validators: Remove undefined where only string value expected (HMS-5354) Jan 20, 2025
@regexowl regexowl merged commit 6918313 into osbuild:main Jan 20, 2025
18 checks passed
@regexowl regexowl deleted the update-validators branch January 20, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgold1234 mgold1234 mgold1234 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@regexowl @mgold1234