Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wizard: Reset error text and validate on plus button (HMS-5329) #2747

Merged
merged 2 commits into from
Jan 22, 2025
Merged

Wizard: Reset error text and validate on plus button (HMS-5329) #2747

merged 2 commits into from
Jan 22, 2025

Conversation

regexowl
Copy link
Collaborator

@regexowl regexowl commented Jan 14, 2025 •
edited by schutzbot
Loading

This updates <ChippingInput> component to resolve two bugs:

  • validation wasn't triggered when using the plus button on Timezone and Locale steps
  • error text wasn't reset when the value was changed or cleared

JIRA: HMS-5329

@regexowl
Copy link
Collaborator Author

/jira-epic HMS-5279

@schutzbot schutzbot changed the title Wizard: Reset error text and validate on plus button Wizard: Reset error text and validate on plus button (HMS-5329) Jan 14, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.73%. Comparing base (adf8021) to head (b7e997c).
Report is 2 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2747      +/-   ##
==========================================
+ Coverage   84.71%   84.73%   +0.01%     
==========================================
  Files         186      186              
  Lines       21241    21248       +7     
  Branches     2083     2087       +4     
==========================================
+ Hits        17995    18005      +10     
+ Misses       3224     3221       -3     
  Partials       22       22
Files with missing lines Coverage Δ
src/Components/CreateImageWizard/ChippingInput.tsx 100.00% <100.00%> (+3.65%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update adf8021...b7e997c. Read the comment docs.

@regexowl regexowl mentioned this pull request Jan 16, 2025
Merged
2 tasks
@regexowl regexowl force-pushed the fix-chipping-input branch 3 times, most recently from e6a42e5 to 73d8980 Compare January 20, 2025 09:03
@regexowl regexowl force-pushed the fix-chipping-input branch 3 times, most recently from 3e68494 to 8e0ebc9 Compare January 21, 2025 12:30
@regexowl
Copy link
Collaborator Author

/retest

@regexowl regexowl added 🐞 bug Something isn't working 🪲 bug fix and removed 🐞 bug Something isn't working labels Jan 21, 2025
@regexowl
Wizard: Reset error text and validate on plus button
c3ee082 
This updates `<ChippingInput>` component to resolve two bugs:
- validation wasn't triggered when using the plus button on Timezone and Locale steps
- error text wasn't reset when the value was changed or cleared
@regexowl
test: Test error message reset and validation on add button
b7e997c 
This tests the updates.
@regexowl
Copy link
Collaborator Author

/retest

@croissanne croissanne enabled auto-merge (rebase) January 22, 2025 10:11
@croissanne croissanne merged commit d41c079 into osbuild:main Jan 22, 2025
17 of 18 checks passed
@regexowl regexowl deleted the fix-chipping-input branch January 22, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@croissanne croissanne croissanne approved these changes

@mgold1234 mgold1234 mgold1234 approved these changes

@lucasgarfield lucasgarfield Awaiting requested review from lucasgarfield

Assignees
No one assigned
Labels
🪲 bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@regexowl @croissanne @mgold1234