on-prem add blueprint pagination and fix filtering (HMS-5306) #2739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39696f9 to
041fd72
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2739 +/- ##
==========================================
- Coverage 84.73% 84.65% -0.09%
==========================================
Files 186 186
Lines 20955 20975 +20
Branches 2033 2033
==========================================
Hits 17756 17756
- Misses 3177 3197 +20
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
79ed0c7 to
53f5d77
Compare
53f5d77 to
32384b9
Compare
32384b9 to
1e08b22
Compare
The blueprint list wasn't being filtered correctly if the blueprint name was specified or if any search terms were provided. This commit fixes that.
Use the filename/id of the blueprints as the links to the first and last element for the blueprint list metadata. These links are a little meaningless since they should be urls.
Add blueprint list pagination support
Get rid of the `Math.floor` for the version and just ensure that the version is a number.
1e08b22 to
2b3db57
Compare
lucasgarfield
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds pagination support for on-prem blueprints and fixes the filtering of blueprints
when trying to search for blueprints.
/jira-epic COMPOSER-2411
JIRA: HMS-5306