Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard: add support of TextArea for ssh_key field (HMS-5304) #2737

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Jan 12, 2025

this commit add support of TextArea for ssh_key field

JIRA: HMS-5304

@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@schutzbot schutzbot changed the title wizard: add support of TextArea for ssh_key field wizard: add support of TextArea for ssh_key field (HMS-5304) Jan 12, 2025
@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch 3 times, most recently from c04883a to 76a85cc Compare January 13, 2025 10:00
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (7d34d30) to head (519883c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...eateImageWizard/steps/Users/component/UserInfo.tsx 80.00% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2737   +/-   ##
=======================================
  Coverage   84.76%   84.77%           
=======================================
  Files         187      187           
  Lines       21285    21298   +13     
  Branches     2095     2099    +4     
=======================================
+ Hits        18042    18055   +13     
  Misses       3221     3221           
  Partials       22       22           
Files with missing lines Coverage Δ
...rc/Components/CreateImageWizard/ValidatedInput.tsx 90.56% <100.00%> (ø)
...mponents/CreateImageWizard/steps/Details/index.tsx 100.00% <100.00%> (ø)
...teImageWizard/steps/FileSystem/FileSystemTable.tsx 71.16% <ø> (ø)
...Wizard/steps/Hostname/components/HostnameInput.tsx 100.00% <100.00%> (ø)
...eImageWizard/steps/TargetEnvironment/Aws/index.tsx 100.00% <100.00%> (ø)
...mageWizard/steps/TargetEnvironment/Azure/index.tsx 100.00% <100.00%> (ø)
...eImageWizard/steps/TargetEnvironment/Gcp/index.tsx 96.39% <100.00%> (ø)
...eateImageWizard/steps/Users/component/UserInfo.tsx 95.14% <80.00%> (+0.04%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d34d30...519883c. Read the comment docs.

@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch 7 times, most recently from abf1bc0 to 38d3edd Compare January 14, 2025 10:20
@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch from 38d3edd to eb28449 Compare January 15, 2025 09:46
@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch 7 times, most recently from 5e4d558 to db659bc Compare January 22, 2025 08:51
@mgold1234 mgold1234 requested a review from avitova January 22, 2025 09:00
@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch from db659bc to 0a9daed Compare January 23, 2025 08:58
this commit add support of TextArea for ssh_key field
@mgold1234 mgold1234 force-pushed the add_textaree_to_hook branch from 0a9daed to 519883c Compare January 24, 2025 13:39
Copy link
Collaborator

@lucasgarfield lucasgarfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working nicely!

@lucasgarfield lucasgarfield merged commit 771a582 into osbuild:main Jan 25, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants