-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wizard: add Administrator checkbox to users step (HMS-4903) #2717
Conversation
b224c1a
to
30864e5
Compare
src/Components/CreateImageWizard/steps/Users/component/UserInfo.tsx
Outdated
Show resolved
Hide resolved
src/Components/CreateImageWizard/steps/Users/component/UserInfo.tsx
Outdated
Show resolved
Hide resolved
An empty |
766b1fa
to
ef66848
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2717 +/- ##
==========================================
+ Coverage 84.69% 84.71% +0.02%
==========================================
Files 186 186
Lines 21199 21241 +42
Branches 2076 2083 +7
==========================================
+ Hits 17955 17995 +40
- Misses 3222 3224 +2
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
4d51518
to
474bae9
Compare
8155881
to
ce05e17
Compare
ce05e17
to
db2f598
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, works nicely.
Please add tests for both edit
and import
mode where isAdmin === true
.
e19c8fe
to
ea48013
Compare
6f6d3b3
to
c4f72ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I genuinely love that we have this split into more pull requests!
b04bf98
to
41fb4dd
Compare
6031f54
to
999b5c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few nitpicks. otherwise looks good :)
src/test/Components/CreateImageWizard/steps/Users/Users.test.tsx
Outdated
Show resolved
Hide resolved
src/test/Components/CreateImageWizard/steps/Users/Users.test.tsx
Outdated
Show resolved
Hide resolved
e85b3a0
to
878abd7
Compare
@mgold1234 there are some conflicts after merging the username validation, can you please resolve them? |
this commit add Administrator checkbox to users step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
import
tests will need to be added after adding user customization to on-prem mapper. Adding edit
tests might be safer when the step functionality is fully implemented as well. That way we don't forget to update them with new fields.
I've created a checklist task in JIRA to track what was already done and what still needs to be addressed.
Import tests need to be coupled with changes to on-prem mapper, edit tests can be also split. I've created a JIRA task to track what's already done for the Users step. That way we don't forget about the tests later.
this commit add Administrator checkbox to users step