Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wizard: add user name validation (HMS-5285) #2716

Merged
merged 1 commit into from
Jan 21, 2025
Merged

wizard: add user name validation (HMS-5285) #2716

merged 1 commit into from
Jan 21, 2025

Conversation

mgold1234
Copy link
Collaborator

@mgold1234 mgold1234 commented Jan 5, 2025 •
edited by schutzbot
Loading

this commit add validation to name field in Users step

JIRA: HMS-5285

@mgold1234 mgold1234 marked this pull request as draft January 5, 2025 20:27
@mgold1234 mgold1234 force-pushed the add_validation_name branch 2 times, most recently from d3d3c2d to ccc9774 Compare January 6, 2025 07:25
@codecov Codecov
Copy link

codecov bot commented Jan 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.69%. Comparing base (5a7ce1e) to head (567749f).
Report is 1 commits behind head on main.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2716      +/-   ##
==========================================
+ Coverage   84.67%   84.69%   +0.02%     
==========================================
  Files         186      186              
  Lines       21168    21199      +31     
  Branches     2069     2075       +6     
==========================================
+ Hits        17924    17955      +31     
  Misses       3222     3222              
  Partials       22       22
Files with missing lines Coverage Δ
...Components/CreateImageWizard/CreateImageWizard.tsx 99.50% <100.00%> (+<0.01%) ⬆️
...eateImageWizard/steps/Users/component/UserInfo.tsx 93.90% <100.00%> (-0.15%) ⬇️
...ents/CreateImageWizard/utilities/useValidation.tsx 97.88% <100.00%> (+0.25%) ⬆️
src/Components/CreateImageWizard/validators.ts 94.62% <100.00%> (+0.57%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a7ce1e...567749f. Read the comment docs.

@mgold1234 mgold1234 force-pushed the add_validation_name branch 8 times, most recently from 79e39b7 to 7b8f6cb Compare January 8, 2025 10:59
@mgold1234 mgold1234 changed the title <wip>- Add validation name wizard: add user name validation (HMS-4903) Jan 8, 2025
@mgold1234 mgold1234 marked this pull request as ready for review January 8, 2025 11:00
@mgold1234 mgold1234 requested review from lucasgarfield and regexowl and removed request for lucasgarfield January 8, 2025 11:00
@mgold1234 mgold1234 force-pushed the add_validation_name branch from 7b8f6cb to 6dc10b7 Compare January 8, 2025 11:16
@mgold1234 mgold1234 marked this pull request as draft January 8, 2025 11:33
@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@mgold1234 mgold1234 force-pushed the add_validation_name branch from 6dc10b7 to 5d2940d Compare January 8, 2025 13:49
@mgold1234 mgold1234 marked this pull request as ready for review January 8, 2025 14:28
@mgold1234
Copy link
Collaborator Author

/jira-epic HMS-4181

@regexowl regexowl changed the title wizard: add user name validation (HMS-4903) wizard: add user name validation Jan 8, 2025
@regexowl
Copy link
Collaborator

regexowl commented Jan 8, 2025

/jira-epic HMS-4181

@schutzbot schutzbot changed the title wizard: add user name validation wizard: add user name validation (HMS-5285) Jan 8, 2025
@mgold1234 mgold1234 force-pushed the add_validation_name branch 3 times, most recently from ee76643 to 20f717f Compare January 12, 2025 13:23
croissanne
croissanne requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@croissanne croissanne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm it seems you pushed another commit to the PR? Could you edit the commit message to conform to the usual standards?

@mgold1234 mgold1234 force-pushed the add_validation_name branch from 060fd9a to f9a3bc9 Compare January 20, 2025 16:18
@mgold1234
Copy link
Collaborator Author

@croissanne removed the other commit to different pr, becuase it seems a different work, sorry for that

croissanne
croissanne previously approved these changes Jan 20, 2025
View reviewed changes
@croissanne croissanne enabled auto-merge (rebase) January 20, 2025 18:49
@mgold1234 mgold1234 force-pushed the add_validation_name branch 17 times, most recently from d702287 to 49c1d8d Compare January 21, 2025 08:55
regexowl
regexowl approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@regexowl regexowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ❤️

@regexowl regexowl force-pushed the add_validation_name branch from 49c1d8d to 567749f Compare January 21, 2025 09:07
@regexowl
Copy link
Collaborator

/retest

@regexowl regexowl dismissed lucasgarfield’s stale review January 21, 2025 10:36

changes should be fine, regex can be fine tuned in a follow up if needed

@croissanne croissanne merged commit 30d77fa into osbuild:main Jan 21, 2025
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regexowl regexowl regexowl approved these changes

@croissanne croissanne croissanne left review comments

@lucasgarfield lucasgarfield Awaiting requested review from lucasgarfield

@avitova avitova Awaiting requested review from avitova

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgold1234 @regexowl @croissanne @avitova @lucasgarfield