-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wizard: Add Kernel name input (HMS-5204) #2690
Conversation
/jira-epic HMS-5192 |
a566648
to
219ea02
Compare
219ea02
to
7fb5c5f
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #2690 +/- ##
==========================================
+ Coverage 84.66% 84.77% +0.10%
==========================================
Files 186 186
Lines 21008 21182 +174
Branches 2035 2067 +32
==========================================
+ Hits 17787 17957 +170
- Misses 3199 3203 +4
Partials 22 22
Continue to review full report in Codecov by Sentry.
|
/retest |
return ( | ||
kernelName.length < 65 && | ||
/^[a-z0-9]|[a-z0-9][a-z0-9-]*[a-z0-9]$/.test(kernelName) | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not completely sure about the validation pattern. Didn't find much information in blueprint reference or stages 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I've learned is that when a kernel is specified, DNF is actually used to install it. So it would need to follow whatever the rules for package names in DNF are. I'm sure there must be a standard for that we can find, although my Google-fu has failed me. I did find something for Ubuntu:
I think if we could find something similar for RH we would have our answer.
7fb5c5f
to
7935272
Compare
7935272
to
36f80da
Compare
Replaced the input with a simple select in new commit. Can squash later if needed, but wanted to see if this makes more sense first. |
36f80da
to
ac5b08f
Compare
@regexowl it is looking awsome! |
ac5b08f
to
3369c4b
Compare
/retest |
3369c4b
to
5e47fb6
Compare
5e47fb6
to
73bbf94
Compare
Hmm, but rt fails immediately... |
Tried to create a blueprint via API (below) and rt failed immediately, same as via UI. {
"name": "kernel-name",
"description": "",
"distribution": "rhel-9",
"image_requests": [
{
"architecture": "x86_64",
"image_type": "guest-image",
"upload_request": {
"options": {},
"type": "aws.s3"
}
}
],
"customizations": {
"kernel": {
"name": "kernel-debug"
}
}
} |
73bbf94
to
ca728a3
Compare
/retest |
b5e7401
to
0ce54ce
Compare
@lucasgarfield I've removed the validator for now as it isn't used anywhere. |
Adding custom name option. |
e650688
to
4f7f81e
Compare
Wasn't sure if we want the alert or not. There's a validation for the kernel name format, but even if that passes the build might fail with kernel package that's not included. |
37d0e93
to
d814450
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, though I wonder if something like a text input with a suggestion autocomplete exists? so we could suggest the default options?
d814450
to
753f040
Compare
/retest |
1 similar comment
/retest |
This adds a kernel name input.
This replaces the kernel name input with a static drop down populated with valid values.
We currently don't use this validator.
This replaces previously used single dropdown with a typeahead that allow creating a custom option.
This adds a warning when custom kernel name is selected.
This adds validation for the Kernel step.
753f040
to
d66f7db
Compare
This adds a kernel name input.
JIRA: HMS-5204