-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
main: add ostree integration (HMS-5302) #53
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How does this behave if --ostree* is given to a non-ostree image type? We should probably return an error. Same for the opposite case - no ostree options for an ostree-enabled image type.
Thanks for the review! I added two tests that ensure the cases are handled correctly. |
f07d109
to
551b43c
Compare
Seems like there are some actual test case failures while building the RPMs:
|
This commit adds integration for the ostree options. It is modelled loosely after weldr-client/composer-cli and the ``` start-ostree --{ref,parent,url} ``` and uses ``` --ostree-{ref,parent,url} ``` A simple smoke test is provided that uses fedora-iot. Ideas welcome for an easier way :)
This commit adds integration for the ostree options. It is modelled loosely after weldr-client/composer-cli and the
and uses
This now has a smoke test based on fedora-iot, ideas for improvements here are welcome!
/jira-epic COMPOSER-2418
JIRA: HMS-5302