Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use librepo for centos-9 too #822

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

mvo5
Copy link
Collaborator

@mvo5 mvo5 commented Feb 5, 2025

This commit switches centos-9 to use librepo as well. This is a bit sad because it means we have no repo anymore that uses the default "curl" backend. But even the centos9 mirrors are now so unreliable that we cannot get things merged.

We should switch the default downloader here to librepo but we need some downstream test that ensures that subscribed content can still be installed with librepo (it should work but there is no explicit test in our testsuite).

(failing test, e.g. https://github.com/osbuild/bootc-image-builder/actions/runs/13134326900/job/36704112622?pr=818, re-run three times now)

This commit switches centos-9 to use librepo as well. This is a
bit sad because it means we have no repo anymore that uses the
default "curl" backend. But even the centos9 mirrors are now so
unreliable that we cannot get things merged.

We should switch the default downloader here to librepo but we
need some downstream test that ensures that subscribed content
can still be installed with librepo (it should work but there
is no explicit test in our testsuite).
Copy link
Member

@ondrejbudai ondrejbudai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks! :)

@achilleas-k
Copy link
Member

This is a bit sad because it means we have no repo anymore that uses the default "curl" backend.

But that's rested everywhere else so I think that's fine.

@achilleas-k achilleas-k enabled auto-merge February 5, 2025 12:51
@achilleas-k achilleas-k added this pull request to the merge queue Feb 5, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 5, 2025
@mvo5 mvo5 added this pull request to the merge queue Feb 5, 2025
Merged via the queue into osbuild:main with commit 749dc5f Feb 5, 2025
9 of 12 checks passed
@mvo5 mvo5 deleted the use-librepo-for-centos9 branch February 5, 2025 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants