progress: fix missing build log output on errors in progress #820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a silly mistake from PR#810. The issue is that in osbuild#810 we started to collect the osbuild stdout/stderr so that we can show crashes from osbuild or other unexpected output. However when a stage fails this is reported via the json progress and not directly on stdout/stderr - this was missed when osbuild#810 was done. This commit does a short term fix by collecting the buildlog again and showing it in the error and also updates the test to be more realistic. However we really need a test that actually tests the real behavior, ideally a real osbuild run with a stage error so that we can be sure we capture this (criticial!) functionality.
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Feb 6, 2025
This commit updates the `progress` package to get the latest fixes, most notably osbuild/bootc-image-builder#820
mvo5
added a commit
to mvo5/image-builder-cli
that referenced
this pull request
Feb 6, 2025
This commit updates the `progress` package to get the latest fixes, most notably osbuild/bootc-image-builder#820
supakeen
pushed a commit
to mvo5/image-builder-cli
that referenced
this pull request
Feb 10, 2025
This commit updates the `progress` package to get the latest fixes, most notably osbuild/bootc-image-builder#820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a silly mistake from PR#810. The issue is that in #810 we started to collect the osbuild stdout/stderr so that we can show crashes from osbuild or other unexpected output.
However when a stage fails this is reported via the json progress and not directly on stdout/stderr - this was missed when #810 was done.
This commit does a short term fix by collecting the buildlog again and showing it in the error and also updates the test to be more realistic. However we really need a test that actually tests the real behavior, ideally a real osbuild run with a stage error so that we can be sure we capture this (criticial!) functionality.