progress: set --cache-max-size in osbuild #812
Conversation
This commit adds catpure of os.Std{out,err} when running osbuild so
that we capture the error log and can display it as part of
an error from osbuild, e.g. when osbuild itself crashes.
This gives us more accurate error reporting if anything fails
during the osbuild building.
This commit tweaks an issue that potentially an incorrect status from osbuild would fail the build with a bad error message and without us getting the full buildlog.
This commit adds a `OSBuildOptions` struct that can be used to pass (optional) options to the `progress.RunOSBuild()` helper. This make it easier to expand with more options.
This commit adds a new `BuildLog` option to the `OSBuildOptions` that can be used to generate a streamed buildlog (e.g. to a file or a websocket). This will be used in `ibcli` with a new `--with-buildlog` option.
This commit allows controlling the `osbuild --cache-max-size` option. By default it will set the cache to 20GiB but allows this to be controlled by the user. Thanks to Simon for raising this.
There was a problem hiding this comment.
Happy about this; a quick note on the size. A single Fedora Minimal build takes up about 10 GiB of space so 20 GiB is indeed a decent minimum.
Note also that due to how we setup pipelines right now basically no output gets cached (at least in in the image-builder-case, I didn't verify the bootc-image-builder case yet).
|
Without checkpoints, osbuild will only cache sources. |
No checkpoints there. Actually, we never set any checkpoints in osbuild-composer or bootc-image-builder (so far). |
It would be 'OK' to pass Perhaps it'd be fine to then only pass |
[draft as this needs https://github.com//pull/811 so that we have a single way to run osbuild plus can actually control its options (which images:osbuild cannot currently]
This commit allows controlling the
osbuild --cache-max-sizeoption. By default it will set the cache to 20GiB but allows
this to be controlled by the user.
Thanks to Simon for raising this.