main: double container size as the min size of "/" (HMS-3810) #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
reviewed
Mar 19, 2024
5e60195 to
89219b6
Compare
cgwalters
previously approved these changes
Mar 20, 2024
89219b6 to
5f862f0
Compare
cgwalters
previously approved these changes
Mar 20, 2024
5f862f0 to
55bdd4d
Compare
db1fe47 to
ce79609
Compare
|
Sorry for the force pushes, I cleaned the commits up a bit and I think this is fnally ready and tests are also happy. |
As a starting point for the image size we use the container size and just double it.
Ensure that the disk size of a container is taken into account when the image is generated. The current heuristic is that we just double the container size. The test will not build an image just generate a manifest and check that the image file is generated with the expected size.
ce79609 to
2a1d06e
Compare
achilleas-k
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a starting point for the image size we use the container size and just double it.