-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMS-3162: tests: add basic integration testing #24
Conversation
7754208
to
d1adda3
Compare
1cfbb79
to
2ea53d3
Compare
2ea53d3
to
ee3e066
Compare
I clicked the rebase button. The linter was failing because the branch was from before the repo and package rename so it was failing. |
ed3cfd3
to
d25af5a
Compare
@mvo5 Just fyi, I changed to PR title because the Jira reference needs to be a prefix for the automation to pick it up and link it. |
Thanks @ochosi ! Maybe it's just me (or me just not being used to this) but I wonder if we could change the automation to look at the end? I find it aesthetically more pleasing to keep the existing form of |
This commit adds basic integration testing for the project. It is pytest based and can run both locally or via `tmt` [0] which will spin up a clean VM and run the tests inside. [0] https://github.com/teemtee/tmt
I wholeheartedly agree, but it seems this is hardcoded in Jira's DVCS plugin, so there's little we can do about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing, thanks!
This commit adds basic integration testing for the project. It is pytest based and can run both locally or via
tmt
[0] which will spin up a clean VM and run the tests inside.See https://github.com/osbuild/osbuild-deploy-container/compare/main...mvo5:tmt-smoke?expand=1#diff-5de36acd90308dc62abf7855a686ee7052ffb6e762c756fd735fb0c9fbd9595dR1 (tests/README.md) for a very basic description.
There are still some TODOs that need addressing (here or in followups):
ContainerBuildable
flag to OSTreeDiskImage images#287)I personally think that as it is it is already useful and we could merge and iterate but I'm equally happy to flesh it out more. It will already do a container build/run/validate that something got generated.
[0] https://github.com/teemtee/tmt