Skip to content

Commit

Permalink
fixup! add comment about progress terminal detection
Browse files Browse the repository at this point in the history
  • Loading branch information
mvo5 committed Dec 10, 2024
1 parent 2c614d2 commit 895a45f
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions bib/internal/progress/progress.go
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ func New(progress string) ProgressBar {
case "", "null":
return NewNullProgressBar()
case "text":
// XXX: this needs to fallback to non-pb if not on a
// terminal, pb Start() will error and Stop() will hang
// otherwise
return NewTermProgressBar()
case "debug":
return NewDebugProgressBar()
Expand Down

0 comments on commit 895a45f

Please sign in to comment.