Skip to content

Commit

Permalink
README: update to show that config.{toml,yaml} can be read-only
Browse files Browse the repository at this point in the history
As suggested by Charlie Drage (thank you!) this commit makes the
mounting of the `config.{toml,yaml}` read-only via the `:ro`
suffix.

The tests are also updated to validate that this works as expected.

Closes: #533
  • Loading branch information
mvo5 authored and achilleas-k committed Jul 11, 2024
1 parent 573da8b commit 64a2f5d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ sudo podman run \
--privileged \
--pull=newer \
--security-opt label=type:unconfined_t \
-v $(pwd)/config.toml:/config.toml \
-v $(pwd)/config.toml:/config.toml:ro \
-v $(pwd)/output:/output \
-v /var/lib/containers/storage:/var/lib/containers/storage \
quay.io/centos-bootc/bootc-image-builder:latest \
Expand Down Expand Up @@ -288,7 +288,7 @@ sudo podman run \
--privileged \
--pull=newer \
--security-opt label=type:unconfined_t \
-v $(pwd)/config.toml:/config.toml \
-v $(pwd)/config.toml:/config.toml:ro \
-v $(pwd)/output:/output \
quay.io/centos-bootc/bootc-image-builder:latest \
--type qcow2 \
Expand Down
4 changes: 2 additions & 2 deletions test/test_manifest.py
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ def test_manifest_user_customizations_toml(tmp_path, build_container):
"podman", "run", "--rm",
"--privileged",
"-v", "/var/lib/containers/storage:/var/lib/containers/storage",
"-v", f"{config_toml_path}:/config.toml",
"-v", f"{config_toml_path}:/config.toml:ro",
"--security-opt", "label=type:unconfined_t",
"--entrypoint=/usr/bin/bootc-image-builder",
build_container,
Expand Down Expand Up @@ -266,7 +266,7 @@ def test_manifest_installer_customizations(tmp_path, build_container):
"podman", "run", "--rm",
"--privileged",
"-v", "/var/lib/containers/storage:/var/lib/containers/storage",
"-v", f"{config_toml_path}:/config.toml",
"-v", f"{config_toml_path}:/config.toml:ro",
"--security-opt", "label=type:unconfined_t",
"--entrypoint=/usr/bin/bootc-image-builder",
build_container,
Expand Down

0 comments on commit 64a2f5d

Please sign in to comment.