Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproducible builds problem #437

Closed
bmwiedemann opened this issue Dec 19, 2024 · 1 comment · Fixed by #438
Closed

reproducible builds problem #437

bmwiedemann opened this issue Dec 19, 2024 · 1 comment · Fixed by #438

Comments

@bmwiedemann
Copy link

While working on reproducible builds for openSUSE (sponsored by the NLnet NGI0 fund), I found that
our tiny package varies in every build.

Another developer pointed at HashMaps in

use std::collections::HashMap;

with non-deterministic iteration order.

Maybe it could be replaced with indexmap, ordermap or something else...

osa1 added a commit that referenced this issue Dec 19, 2024
This make map iteration deterministic and makes tiny builds
reproducible.

Fixes #437.
@osa1 osa1 closed this as completed in #438 Dec 19, 2024
@osa1 osa1 closed this as completed in 075c0bf Dec 19, 2024
@osa1
Copy link
Owner

osa1 commented Dec 19, 2024

Thanks for reporting this. You were right that the hash map in the macro was the cause. I've updated it to IndexMap and made 10 builds and they were all identical, so the issue should be fixed. Please re-open if it isn't.

ralphptorres added a commit to ralphptorres/packages that referenced this issue Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants