Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scrollback limit sometimes causes scrolling too much #265

Closed
osa1 opened this issue Nov 14, 2020 · 1 comment · Fixed by #266
Closed

Scrollback limit sometimes causes scrolling too much #265

osa1 opened this issue Nov 14, 2020 · 1 comment · Fixed by #266
Labels
bug libtiny_tui Issues/PRs related to the TUI library

Comments

@osa1
Copy link
Owner

osa1 commented Nov 14, 2020

It seems like there's currently a bug when removing old lines when scrollback is enabled where I can scroll past the oldest line.

I'm guessing in some cases the same bug would also cause not being able to scroll enough to see the oldest line, but I haven't encountered this case yet.

To reproduce: set the scrollback something small. 100 works fine in my case. Then leave the client running for a while in an active channel. Every once in a while try to scroll to the top using page-up/down. You'll end up with a screen like:

---------------
<empty>
<empty>
<empty>
old line
old line
---------------

What should happen instead is I should not be able to scroll after the oldest line is at the top:

---------------
old line
old line
old line
old line
old line
---------------
@osa1 osa1 added bug libtiny_tui Issues/PRs related to the TUI library labels Nov 14, 2020
@osa1
Copy link
Owner Author

osa1 commented Nov 14, 2020

Resizing the window fixes the issue.

trevarj added a commit to trevarj/tiny that referenced this issue Nov 14, 2020
@trevarj
Fixed bug with scrollback limit.
0aa50d6 
When a line is removed due to reaching scrollback limit, update the
message area's line height. Added test to assert the height is being
maintained.

Closes osa1#265
@trevarj trevarj mentioned this issue Nov 14, 2020
Merged
osa1 pushed a commit to trevarj/tiny that referenced this issue Nov 15, 2020
@trevarj @osa1
Fixed bug with scrollback limit.
1edf410 
When a line is removed due to reaching scrollback limit, update the
message area's line height. Added test to assert the height is being
maintained.

Closes osa1#265
@osa1 osa1 closed this as completed in #266 Nov 15, 2020
osa1 pushed a commit that referenced this issue Nov 15, 2020
@trevarj
Fixed bug with scrollback limit. (#266)
8f31f5f 
When a line is removed due to reaching scrollback limit, update the
message area's line height. Added test to assert the height is being
maintained.

Closes #265
osa1 added a commit that referenced this issue Nov 15, 2020
@osa1
Update CHANGELOG for #265
8af99c9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug libtiny_tui Issues/PRs related to the TUI library
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed bug with scrollback limit. trevarj/tiny
1 participant
@osa1