Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow naming servers to give them a better display name #186

Closed
e00E opened this issue Apr 13, 2020 · 3 comments
Closed

Allow naming servers to give them a better display name #186

e00E opened this issue Apr 13, 2020 · 3 comments
Labels
feature request

Comments

@e00E
Copy link
Contributor

e00E commented Apr 13, 2020

Currently the address of the server is used to display the server tab. For some servers this can be unhelpful (ip address) or too long (very long domain name). I would like to be able to give my servers a helpful name in the config. This name would be used instead.
@trevarj
Copy link
Contributor

trevarj commented Apr 13, 2020

Implementing feature here:
#188

trevarj added a commit to trevarj/tiny that referenced this issue Apr 14, 2020
@trevarj
Allow server alias in config
cc2119a 
Fixed osa1#186
trevarj added a commit to trevarj/tiny that referenced this issue Apr 14, 2020
@trevarj
Allow server alias in config
b608eda 
Fixed osa1#186
trevarj added a commit to trevarj/tiny that referenced this issue Apr 14, 2020
@trevarj
Allow servers to have aliases. Fixes osa1#186.
1fc1944
osa1 pushed a commit to trevarj/tiny that referenced this issue Apr 14, 2020
@trevarj @osa1
Allow servers to have aliases. Fixes osa1#186.
8c04990
osa1 pushed a commit to trevarj/tiny that referenced this issue Apr 14, 2020
@trevarj @osa1
Allow servers to have aliases. Fixes osa1#186.
6c06540
@osa1 osa1 closed this as completed in 9609a9a Apr 14, 2020
@osa1
Copy link
Owner

osa1 commented Apr 14, 2020

This is now implemented. Just add an alias field to your server configuration. Example:

    - addr: chat.freenode.net
      alias: freenode
      ...

Here in the tab line you'll see freenode instead of chat.freenode.net as before.

@e00E
Copy link
Contributor Author

e00E commented Apr 14, 2020

Thank you osa and trevarj.

trevarj added a commit to trevarj/tiny that referenced this issue May 3, 2020
@trevarj
Allow servers to have aliases. Fixes osa1#186.
04cd3d8
trevarj added a commit to trevarj/tiny that referenced this issue May 20, 2020
@trevarj
Implement wrapping in text field
54893ee 
Closes osa1#101

Update tests:

- Improve error reporting on test failure
- Use smaller screen in text_field_wrap tests, document screen size
- Combine multiple text_field_wrap tests in single test
  (not complete)

Fix a few clippy warnings

tui: Implement methods for testing resizing

Allow servers to have aliases. Fixes osa1#186.

Remove outdated contributors list from README

We don't update it, and Github maintains an up-to-date list for us
anyway (in 'contributors' page).

Test resizing

Fixed test after rebase with master

Added word wrapping on text field input

Fix for line calculation.

Added indentation for message lines

Fixed bug with Line::rendered_height not calculating based on timestamp and nick length

Implement wrapping in text field

Closes osa1#101

Update tests:

- Improve error reporting on test failure
- Use smaller screen in text_field_wrap tests, document screen size
- Combine multiple text_field_wrap tests in single test
  (not complete)

Test resizing

Formatting

Fixed test after rebase with master

Added word wrapping on text field input

Fix for line calculation.

Added indentation for message lines

Fixed bug with Line::rendered_height not calculating based on timestamp and nick length

- moved text_field to own module - input_area
- started making TextArea work like MsgArea, new InputLine like Line

Working more on wrapping...autocomplete still buggy

buffer remove fix.

Progress on wrapping, added some tests - need more

Autocompletion - hacky solution

Not resizing msg_area every draw - only on height change

Caching textarea height so that we only need to calculate lines on modify() or resize()
trevarj added a commit to trevarj/tiny that referenced this issue Jun 6, 2020
@trevarj
Implement wrapping in text field
dfd080d 
Closes osa1#101

Update tests:

- Improve error reporting on test failure
- Use smaller screen in text_field_wrap tests, document screen size
- Combine multiple text_field_wrap tests in single test
  (not complete)

Fix a few clippy warnings

tui: Implement methods for testing resizing

Allow servers to have aliases. Fixes osa1#186.

Remove outdated contributors list from README

We don't update it, and Github maintains an up-to-date list for us
anyway (in 'contributors' page).

Test resizing

Fixed test after rebase with master

Added word wrapping on text field input

Fix for line calculation.

Added indentation for message lines

Fixed bug with Line::rendered_height not calculating based on timestamp and nick length

Implement wrapping in text field

Closes osa1#101

Update tests:

- Improve error reporting on test failure
- Use smaller screen in text_field_wrap tests, document screen size
- Combine multiple text_field_wrap tests in single test
  (not complete)

Test resizing

Formatting

Fixed test after rebase with master

Added word wrapping on text field input

Fix for line calculation.

Added indentation for message lines

Fixed bug with Line::rendered_height not calculating based on timestamp and nick length

- moved text_field to own module - input_area
- started making TextArea work like MsgArea, new InputLine like Line

Working more on wrapping...autocomplete still buggy

buffer remove fix.

Progress on wrapping, added some tests - need more

Autocompletion - hacky solution

Not resizing msg_area every draw - only on height change

Caching textarea height so that we only need to calculate lines on modify() or resize()

Fixes after my bad rebase

Fixed nickname not showing on tiny window.

Fixed PR feedback:
- Nickname suffix is now static
- removed pub from some functions

Fixes for PR:
- Removes text_field_wrap config. Defaulting to text wrapping, falling
back to scroll when width is too small.
- Reverted indenting for message area.

Fixed issue with calculate_lines() where it would not correctly calculate when there were multi-line words.

Another rework. Exhaustive wrapping algorithm. Removed keeping track of white spaces. Added keeping track of line starts for easy wrapped drawing. No more crazy BTree insert/remove code.

Added fallback to scroll after input area is greater than half of the
screen height.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@osa1 @e00E @trevarj